Add playwright test from Sonner package and fix dismiss function #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2024 13:59
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CMarzin
changed the title
@CMarzin I will check it later, it seems development has some issues. @CMarzin OK, you can remove the Maybe it will pass the development.
|
|
Thanks i have now fixed the lock file, I used an old version of pnpm. |
|
@CMarzin Thank you for the excellent work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @xiaoluoboding can you check this pull request to see if this is ok for you ?
This pull requests adds :
All the test pass except for this one "return focus to the previous focused element"
I can't see why the deploy why the deploy failed on Vercel can you share the log maybe so I can fix this error ?